Feature: Code Editor modal, adds pretty-print support #18123
Merged
+28
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
formatOnLoadoption to the Code Editor modal configuration.When enabled, once the Monaco editor has loaded, the
'editor.action.formatDocument'action is ran against it to pretty-print the code contents. Currently, this only seems to work when usingsetTimeoutto delay the action execution.How to test?
Load up a Tiptap RTE, (the more content the better, e.g. more than a couple of paragraphs), press the "View Source Code" toolbar button. See the Code Editor modal opens and that the code contents is formatted, (e.g. on multiple lines, not on a single line).