Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass user Id to audit when saving and deleting members #18120

Conversation

AndyButland
Copy link
Contributor

Prerequisites

  • I have added steps to test this contribution in the description below

Fixes #18116

Description

As noted in the linked issue, we have details of the user performing the action in the service methods for saving and deleting members, but we aren't passing those to the audit recording.

With this PR merged, the audit log will record the performing user for these actions.

To Test:

  • Save and/or delete a member
  • Query the audit records and note that the record written is associated with the user you are logged in as:
select top 5 * from umbracoAudit order by id desc

Sorry, something went wrong.

Copy link
Contributor

@nikolajlauridsen nikolajlauridsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nikolajlauridsen nikolajlauridsen merged commit bca74e0 into v15/dev Jan 29, 2025
28 checks passed
@nikolajlauridsen nikolajlauridsen deleted the v15/bugfix/audit-performing-user-when-modifying-members branch January 29, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants