Fix: media picker mandatory validation #18109
Merged
+113
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leekelleher
requested changes
Jan 27, 2025
There was a problem hiding this comment.
@nielslyngsoe I've tested it out, but I'm having issues removing a media item (when there is only 1 item). I suspect it's to do with the missingCards check? 🤔
I've also noticed that the valueMissing validator is triggered regardless of whether the property-editor was mandatory or not.
|
@leekelleher Oh, I've been too shift in implementing these. Thanks for begin so aware 👏 Its corrected now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes Media Picker react to Mandatory setting + getting the mandatory message. + and a few minor clean ups.
Also notice how the Rich Media Input now uses a UmbRepositoryItemsManager, for a better request flow.