Tiptap RTE: Add CSS support for extensions #18075
Merged
+177
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Umbraco.Web.UI.Client/src/packages/tiptap/components/input-tiptap/input-tiptap.element.ts
iOvergaard
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature is intended for Umbraco 15.3.
Introduces a
getStyles()method for Tiptap extensions. This enables an individual Tiptap extension to define their own CSS rules.For the initial implementation, the CSS rules for extensions were all placed within the
umb-input-tiptapcomponent regardless whether they are enabled or not.This PR moves the CSS rules for the built-in Embedded Media, Image and Table to its own extension.
How to test
With the Tiptap RTE, enable any of the following extensions (Embedded Media, Image and/or Table), load up the RTE on a document, are the styles for those extensions present?