Add NoopCurrentMemberClaimsProvider so Umbraco can boot without the Delivery API enabled #18049
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elivery API enabled
Migaroez
approved these changes
Jan 21, 2025
Migaroez
pushed a commit
that referenced
this pull request
Jan 21, 2025
…elivery API enabled (#18049)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The introduction of the "current member info" endpoint for the Delivery API unfortunately means Umbraco no longer can boot without the Delivery API 😢
This PR fixes it, by adding a
NoopCurrentMemberClaimsProviderand moving theICurrentMemberClaimsProviderinterface to core. This follows the pattern of all the other Delivery API services required for boot.Breaking change?
This looks very breaking, but as it happens, the feature is not yet released (slated for 13.6), so we can break it 👍