Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix settings value begin indifference (17989) #18022

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Fix settings value begin indifference (17989) #18022

merged 1 commit into from
Jan 21, 2025
+25 −22

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Jan 17, 2025 •
edited
Loading

Fixes #17989

aligning the methods, the issue was that the settingsValues was not comparing property alias.

@johnpscott johnpscott mentioned this pull request Jan 21, 2025
Closed
1 task
@leekelleher leekelleher self-requested a review January 21, 2025 16:01
leekelleher
leekelleher approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@leekelleher leekelleher merged commit 800873c into v15/dev Jan 21, 2025
30 checks passed
@leekelleher leekelleher deleted the v15/bugfix/17989 branch January 21, 2025 16:43
@leekelleher leekelleher mentioned this pull request Jan 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leekelleher leekelleher

Assignees
No one assigned
Labels
area/frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nielslyngsoe @leekelleher