Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue with double reversed url segments #17477

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Fixed issue with double reversed url segments #17477

merged 3 commits into from
Nov 11, 2024
+27 −8

Conversation

bergmania
Copy link
Member

Description

After #17443 the urls without a domain is reversed twice.

Tests

  • Setup structure without setting a domain. E.g. the starter kit and verify urls looks correct both inbound and outbound

@nikolajlauridsen
Reverse urls in backoffice
Loading
Loading status checks…
9de77b5
@nikolajlauridsen
Remove last segment if rtl and hideTopLevel
Loading
Loading status checks…
9ad9ab7
nikolajlauridsen
nikolajlauridsen approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@nikolajlauridsen nikolajlauridsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tests good 👍 but please have a look at my changes 😄

@bergmania
Copy link
Member Author

Looks good :)

@bergmania bergmania merged commit bcc71de into release/15.0 Nov 11, 2024
12 of 15 checks passed
@bergmania bergmania deleted the v15/hotfix/fix-issue-with-double-reverse-urls branch November 11, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolajlauridsen nikolajlauridsen

Assignees
No one assigned
Labels
release/15.0.0-rc4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bergmania @nikolajlauridsen