-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V15: Implement content type filtering for in-memory navigation structure #17456
Merged
Zeegaan
merged 32 commits into
release/15.0
from
v15/feature/implement-content-type-filtering-for-navigation-str
Nov 11, 2024
Merged
V15: Implement content type filtering for in-memory navigation structure #17456
Zeegaan
merged 32 commits into
release/15.0
from
v15/feature/implement-content-type-filtering-for-navigation-str
Nov 11, 2024
+1,785
−287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
…erences
…v15/feature/implement-content-type-filtering-for-navigation-str
…v15/feature/implement-content-type-filtering-for-navigation-str
Looks good, works great 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
NavigationNode
and loading it from the DB when refreshing the content of the navigation structure;FetchNavigationDtos()
;ContentNavigationServiceBase
and updating its extending classes;TryGetChildrenKeysOfType()
,TryGetDescendantsKeysOfType()
,TryGetAncestorsKeysOfType()
,TryGetSiblingsKeysOfType()
andTryGetRootKeysOfType()
;PublishedContentExtensions
to use the new filtering methods (more performant) instead of using the cache to resolve theIPublishedContent
items and then apply content type filtering;.Parent()
friendly extension method, without a specific type.Test
PublishedContentExtensions
methods in a document type template hasn't changed the functionality;.Parent()
from theFriendlyPublishedContentExtensions
- you can add<h1>Hello from "@Model.Parent().Name"</h1>
to a child template.Template example for
SiblingsOfType()