V14/fix/cookie breaking installer #16993
Merged
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjac
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
During the boot process of a fresh install. The BackofficeDefaultController is hit and if a (timewise) valid cookie is found, the system will try to find the user bound to that cookie, but it can't since there are no users configured yet. So it errors out and breaks the install process
This PR uses the runtime state to figure out whether authentication is even possible in the current state. If not it fails the authentication without blowing up which results in the installer popping up as required.
Testing
To force the bug.
All other calls to the BackofficeDefaultController should be have as before.