Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uploaded item not selected in media picker #16644

Conversation

ealse
Copy link

@ealse ealse commented Jun 21, 2024

Prerequisites

  • I have added steps to test this contribution in the description below

Description

Since the merge of issue #15115, uploaded items are not selected anymore.

Steps to test:

  • Create an Media Picker (Pick multiple items should be off) and upload an image into the media picker.
    Latest uploaded file should be selected.

With the option "Pick multiple items" no item is selected, but this functionality did not do this before the bug was introduced either. That is why no change has been made to this behaviour.

Extra remark:
issue #15115 does not appear to have resolved the problem either. I can still produce the bug.

Sorry, something went wrong.

Copy link

github-actions bot commented Jun 21, 2024

Hi there @ealse, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Sorry, something went wrong.

@ealse ealse force-pushed the v13/bugfix/Media-Picker-upload-not-selecting-uploaded-file branch from 9fb15a9 to 3cd47bf Compare June 21, 2024 13:45
@georgebid
Copy link
Contributor

Hey @ealse, thanks a lot for your PR, I am sorry to see that the previous fix has caused you issues. Someone on the core collaborators team will review this soon! 😄

@emmagarland emmagarland merged commit 7afc2b9 into umbraco:v13/contrib Aug 12, 2024
14 of 15 checks passed
@emmagarland
Copy link
Contributor

Hi @ealse, thanks so much for your pull request to fix the issue of the media item not being selected after uploading,

I can confirm that your fix has returned it to the expected behaviour for the single upload.

It has now been successfully merged targeting v13! 🙌

It also looks like this is your first time contributing to this repository on Umbraco CMS, great work! 🎉

If have an account on our.umbraco.com please feel free to drop a comment below with your account name.

@nul800sebastiaan or @busrasengul will add a lovely new C-Trib badge to your profile. 🏅

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants