added option to disable automatic expand of single nc item

[beliskner]

This feature is a reimplementation of PR: #9883 of @patrickdemooij9 to add an option to disable nested content automatically expanding if the max items is set to 1 and the slider is turned off.
Visual of how this works is posted in attached closed PR.

Can be checked with:

• Create a new nested content with min 0, max 1.
• Whenever you open it on a node, it will automatically open if you have an item in it.
• If you uncheck the new option, it'll not automatically open on load.

[mikecp]

Hi @beliskner,

Thanks for porting the PR of @patrickdemooij9 to V9 as it was a nice addition! 👍

Referring to one of the remarks in the original PR, I will check with HQ if we really need to limit this logic to the situations where there is max 1 item or if we can update the current logic and change it to "apply whenever there is only 1 item".

I also would also suggest to reword a little bit the description of the new property to clarify its usage, but let's first wait for HQ feedback on the logic 😊

I'll come back to you as soon as I have news.

[beliskner]

Hi @mikecp,

Thank you for your response. Looking forward to the feedback. Any suggestion on correct phrasing?

[mikecp]

HI @beliskner,
Not sure yet as this will depend on the feedback, but if we leave it as it is now, probably something like "Item is automatically expanded when there is one item available and maximum one item allowed."
If we adapt the logic to just take the property value into account, I would put something like "Item is automatically expanded when there is a single item available"

I keep you posted on the answer from HQ.

[mikecp]

Hi @beliskner ,

Coming back to you with some feedback from my discussion with HQ.

So, the good news is that we can leave out the "min-max" check and just apply the property value check in all cases where there is only 1 item 🎉

The somewhat "less good" news here is that HQ has released v9.5 RC this week, which is the last minor version of V9. This means that you will need to retarget your PR to the branch V10/contrib, which has just been created and is available in the repository.
But since it is thanks to this switch to V10 that we can simplify the logic (which is a breaking change and would not have been allowed in v9), this is not such a bad news after all I think 😁

I hope you won't mind doing this update, don't hesitate to reach out if you have problems with the retarget.

Thanks!

[mikecp]

Maybe replace "First item" by "A single item" to be more accurate?

[mikecp]

Thanks @beliskner for the update!
I just left a tiny comment, let me know what you think.
Cheers!

[beliskner]

Hi @mikecp thanks for the feedback! I adjusted the copy as per your request. If there's anything else you would like me to change please let me know :)

[mikecp]

Hi @beliskner , sorry for the delay, I just re-checked and it all works fine! So we're all ready to merge 😁

Thanks again for this PR! And since it is your first contribution to the CMS, @nul800sebastiaan will be happy to assign our shiny contributor's badge to you 🎉
All you have to do is provide your account name on Our so that we can link the badge!

Cheers!

[beliskner]

Hi @beliskner , sorry for the delay, I just re-checked and it all works fine! So we're all ready to merge 😁

Thanks again for this PR! And since it is your first contribution to the CMS, @nul800sebastiaan will be happy to assign our shiny contributor's badge to you 🎉 All you have to do is provide your account name on Our so that we can link the badge!

Cheers!

Awesome, thanks! https://our.umbraco.com/members/beliskner/ is my Our profile. Looking forward to contributing more!

[nul800sebastiaan]

Contrib badge added! 👍 Thanks again @beliskner!