Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v15.3.0-rc2 Can't publish content with first attempt #18735

Closed
PeterKvayt opened this issue Mar 19, 2025 · 4 comments
Closed

v15.3.0-rc2 Can't publish content with first attempt #18735

PeterKvayt opened this issue Mar 19, 2025 · 4 comments

Comments

@PeterKvayt
Copy link
Contributor

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.3.0-rc2

Bug summary

Unable to publish content using block list while clicking "Save and publish" for first time. Next time it works like a charm.

Specifics

No response

Steps to reproduce

  1. Fresh umbraco install
  2. Create content type with property with block list (property must be mandatory)

Image

Image

Image

  1. Create node in content

Image

  1. Create a block list element for content

Image

Image

  1. Click "Save and publish" first time

Image

  1. Reload the page and click "Save and publish" one more time

Image

Expected result / actual result

Actual: An error notification occurred "Document could not be published, but we saved it for you" for a first attempt, the next attempts will succeed.
Expected: There is no error "Document could not be published, but we saved it for you " for first "Save and publish attempt".

Copy link

Hi there @PeterKvayt!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@PeterKvayt
Copy link
Contributor Author

PeterKvayt commented Mar 19, 2025

@AndyButland
It seems that it is the similar issue as this issue

@PeterKvayt PeterKvayt changed the title v15.3.0-rc2 Cannot publish content with first attempt v15.3.0-rc2 Can't publish content with first attempt Mar 19, 2025
@AndyButland
Copy link
Contributor

Thanks @PeterKvayt - I can reproduce. Not sure what's going on but I can see when I debug that the server is returning an "it's valid" response. On the client in I can see in UmbSubmittableWorkspaceContextBase here...

public async validate(): Promise<Array<void>> {
  console.log(this.#validationContexts);
  return Promise.all(this.#validationContexts.map((context) => context.validate()));
}

... that there are two validation contexts for the first case that fails, and then only one after you reload the item and successfully save and publish a second time.

I'll share this with the team so we can get it fixed.

nielslyngsoe added a commit that referenced this issue Mar 20, 2025
* fix multiple text string validation

* notify about messages

* cherry picked fix

* protection again unnecessary calls

* json path cherry pick + tests

* validation message change lock

* cherry pick from control lifecycle

* optimization

* propagate errors

* cherry picked sync

* query umb-input-multiple-text-string

* remove unused import

* remove optional chain expression

* use !

* outcomment the error handling

* outcomment more promise rejection error

* Fixed issue with multi URL picker.

* remove unesecary warning

---------

Co-authored-by: Andy Butland <[email protected]>
@AndyButland
Copy link
Contributor

Fixed via #18735 and due in 15.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants