FFT-223 Attrition displayed as a percentage #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaitBarnard
commented
Mar 10, 2025
| // Converts a value greater than 1.0 to percentage: 1.2 = 20% | ||
| // Rounded to prevent decimal precision issues | ||
| return Math.round((value - 1.0) * 100 * 1e10) / 1e10; | ||
| }; |
There was a problem hiding this comment.
There's probably a better way to have these two methods. One is for attrition, the other is pay uplift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display attrition as a percentage but save as a decimal
Display pay uplift as a percentage
Examples
Attrition:
0% = 1.0
1% = 0.99
2.5% = 0.975
Pay uplift:
0% = 1.0
1% - 1.01
2.5% = 1.025
To do:
Suffix with wrapper causes input box to be hidden when page is at a certain size
Scrollable div could be refactored to be in a tab
Error messages when value is not 0 to 100 (0.0 to 1.0 in backend)