Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CICD-base.yaml #85

Merged
merged 2 commits into from
Nov 18, 2023
Merged

Update CICD-base.yaml #85

merged 2 commits into from
Nov 18, 2023

Conversation

nwiltsie
Copy link
Member

@nwiltsie nwiltsie commented Nov 17, 2023

I found another one!

I did have to make one change to add the encoding='utf-8' argument to open() to make pylint happy.

https://pylint.readthedocs.io/en/latest/user_guide/messages/warning/unspecified-encoding.html

For sanity I confirmed that the default encoding used in the docker image is indeed UTF-8:

$ docker run -it --rm --entrypoint /bin/bash ghcr.io/uclahs-cds/pipeval:4.0.0-rc.2
bldocker@e90e52ddfca8:/tool$ python3 -c "import locale; print(locale.getpreferredencoding())"
UTF-8

@nwiltsie nwiltsie requested a review from yashpatel6 November 18, 2023 00:12
Copy link
Collaborator

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yashpatel6 yashpatel6 merged commit af334fe into main Nov 18, 2023
@yashpatel6 yashpatel6 deleted the nwiltsie-update-cicd branch November 18, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants