Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagram #83

Merged
merged 10 commits into from
May 13, 2024
Merged

Add diagram #83

merged 10 commits into from
May 13, 2024

Conversation

yashpatel6
Copy link
Collaborator

Description

Adding flowchart of validation


Checklist

File Commits

  • This PR does NOT contain Protected Health Information (PHI). A repo may need to be deleted if such data is uploaded.
    Disclosing PHI is a major problem1 - Even a small leak can be costly2.

  • This PR does NOT contain germline genetic data3, RNA-Seq, DNA methylation, microbiome or other molecular data4.

  • This PR does NOT contain other non-plain text files, such as: compressed files, images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other output files.

  To automatically exclude such files using a .gitignore file, see here for example.

Code Review Best Practices

  • I have read the code review guidelines and the code review best practice on GitHub check-list.

  • I have set up or verified the main branch protection rule following the github standards before opening this pull request.

  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].

  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

Testing

  • I have added unit tests for the new feature(s).

  • I modified the integration test(s) to include the new feature.

  • All new and previously existing tests passed locally and/or on the cluster.

  • The docker image built successfully on the cluster.

Footnotes

  1. UCLA Health reaches $7.5m settlement over 2015 breach of 4.5m patient records

  2. The average healthcare data breach costs $2.2 million, despite the majority of breaches releasing fewer than 500 records.

  3. Genetic information is considered PHI.
    Forensic assays can identify patients with as few as 21 SNPs

  4. RNA-Seq, DNA methylation, microbiome, or other molecular data can be used to predict genotypes (PHI) and reveal a patient's identity.

@yashpatel6
Copy link
Collaborator Author

As a note, I didn't add PlantUML at this point since there were some edits done outside of PlantUML for this flowchart

@yashpatel6
Copy link
Collaborator Author

Welp the latest pylint has a lot of issues with the .pylintrc file in the CICD image; I'll revert back to blcdsdockerregistry for the moment even though it rejects the repo prefix

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not add an SVG instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited the PNG for the manuscript so I kept that for now; once I add the PlantUML, I'll switch it to the SVG

@yashpatel6 yashpatel6 requested a review from aholmes August 11, 2023 01:39
@yashpatel6 yashpatel6 merged commit 05ca2ea into main May 13, 2024
5 checks passed
@yashpatel6 yashpatel6 deleted the yashpatel-add-diagram branch May 13, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants