Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ABP/EL {remove: true;} as alias for :remove() #3451

Closed
9 tasks done
stephenhawk8054 opened this issue Nov 14, 2024 · 2 comments
Closed
9 tasks done

Support ABP/EL {remove: true;} as alias for :remove() #3451

stephenhawk8054 opened this issue Nov 14, 2024 · 2 comments
Labels
enhancement New feature or request fixed issue has been addressed

Comments

@stephenhawk8054
Copy link
Member

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

Currently ABP is supporting removing elements by {remove: true;}: https://gitlab.com/eyeo/adblockplus/abc/webext-ad-filtering-solution/-/releases/1.3.0

And looks like EL is starting to support that syntax as well: easylist/easylist@99c717fac

So I think we could add alias support for {remove: true;} then we can delegate some filters in uAssets to EL?

A specific URL where the issue occurs.

https://www.euronews.com/next/2024/11/12/europes-answer-to-google-ecosia-and-qwant-partner-to-build-new-search-index

Steps to Reproduce

  1. Check for the filter euronews.com###o-site-hr__leaderboard-wallpaper.u-show-for-xlarge {remove:true;} in EL
  2. The filter is marked as invalid

image

Expected behavior

{remove: true;} filters are supported

Actual behavior

{remove: true;} filters are not supported

uBO version

1.61.0

Browser name and version

Firefox 132.0.2

Operating System and version

Windows 10

@uBlock-user uBlock-user added the enhancement New feature or request label Nov 14, 2024
@uBlock-user
Copy link
Contributor

{remove: true;} filters are supported

AdGuard's {remove: true;} filter is supported, it's just the starting syntax of ABP that is different.

@stephenhawk8054
Copy link
Member Author

stephenhawk8054 commented Nov 14, 2024

Yeah, if I'm not wrong, AG's syntax is

euronews.com#$##o-site-hr__leaderboard-wallpaper.u-show-for-xlarge {remove:true;}

which is supported in uBO.

@uBlock-user uBlock-user added the fixed issue has been addressed label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

2 participants