Upsert Can't handle required 'false' boolean values #197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to run
upsert
command, it errors if passing in a boolean attribute that is 'required' and is set tofalse
. It seemed that the dynamo command created includes the attribute inExpressionAttributeNames
but did not pass through the value correctly into theExpressionAttributeValues
object, it instead sets it toundefined
. This causes the following error to be thrown by the document clientI think I hunted down where the bug came from, it seems it was due to the following line short circuiting on the value of
upsertAttributes[field]
which was fine in most cases, except for when that value equalsfalse
in which case it looks forupdatedKeys[field]
and then value gets assignedundefined
Im not super familiar with the Electro codebase and just hunted this down with some logs etc, but please feel free to redo if what i have done would break anything. I just figured i could hopefully make a good start :)