Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cnpm fails due to $packgeManager not matched #687

Merged
merged 2 commits into from
Apr 9, 2020
Merged

fix: cnpm fails due to $packgeManager not matched #687

merged 2 commits into from
Apr 9, 2020

Conversation

afc163
Copy link
Contributor

@afc163 afc163 commented Mar 10, 2020 •
edited
Loading

close #682
close #676
close cnpm/cnpm#318

Reproduce steps

npm i cnpm -g
git clone [email protected]:afc163/husky-test.git
cd husky-test
cnpm i
touch README && git add README
git commit -am 'commit message'

husky pre-commit is not running.

Reason

$packageManager of husky defined didn't contain cnpm, which is using https://github.com/cnpm/npminstall, the $packageManager value should be npminstall.

Solution

It can be fallback to npx when $packageManager is npminstall.

Additionally, fixed Unknown package manager logic according to #682 in which @MondoGao had described.

@afc163
Copy link
Contributor Author

afc163 commented Mar 10, 2020 •
edited
Loading

resolves ant-design/ant-design-pro#5989
resolves ant-design/ant-design-pro#5882

@afc163 afc163 changed the title fix: cnpm fail cause packgeManager not matched fix: cnpm fails due to $packgeManager not matched Mar 10, 2020
@afc163
Copy link
Contributor Author

afc163 commented Mar 16, 2020

Could anyone see this?

@afc163
Copy link
Contributor Author

afc163 commented Mar 25, 2020

@typicode Any chance to merge this?

@fengmk2
Copy link

fengmk2 commented Apr 9, 2020

+1, anyone can review then merge it?

@typicode
Copy link
Owner

typicode commented Apr 9, 2020

Thanks! 👍

@typicode typicode merged commit 4e1d440 into typicode:master Apr 9, 2020
@afc163 afc163 deleted the fix-cnpm branch April 10, 2020 04:29
@snyk-bot snyk-bot mentioned this pull request Apr 12, 2020
Merged
@afc163 afc163 mentioned this pull request Apr 25, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request May 2, 2020
Merged
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@afc163 @fengmk2 @typicode @MondoGao