Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add userHome, currentWorkingDirectory to Files API #2789

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

armanbilge
Copy link
Member

@armanbilge armanbilge commented Jan 9, 2022

Not entirely sure if Files is the best place for these.

Maybe after typelevel/cats-effect#2650 lands we can add a test that compares to env.

@armanbilge armanbilge changed the title Add userHome, currentWorkingDirectory to Files API Add userHome, currentWorkingDirectory to Files API Jan 9, 2022
@ChristopherDavenport
Copy link
Member

Really looking forward to this, with this plus some env/os-detect actual applications can be written in pure style super straight-forward. Where we can customize where we run, where we save data, etc.

@rossabaker
Copy link
Member

java.io.tmpdir is another meaningful one to the JVM, but I don't know what the Scala.js equivalent would be. Don't block this on that if it's not obvious.

@armanbilge
Copy link
Member Author

We already have facilities for creating temporary files and temporary directories. Is it helpful to expose the tmp dir directly like this?

@rossabaker
Copy link
Member

It's useful for providing the default, but that's already tucked away behind an Option. Distraction withdrawn.

@mpilquist mpilquist merged commit 8b285a6 into typelevel:main Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants