Introduce Chunk.ByteBuffer #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark results: |
rossabaker
commented
Dec 26, 2017
| JByteBuffer.wrap(c.values, c.offset, c.length) | ||
| case c: Chunk.ByteBuffer => | ||
| val b = c.buf.asReadOnlyBuffer | ||
| if (c.offset == 0 && b.position == 0 && c.size == b.limit) b |
There was a problem hiding this comment.
I don't know that this actually saves a lot. This trick is inspired by scodec.bits.ByteVector.
| // } | ||
|
|
||
| // "map.long => long" in forAll { c: Chunk[Long] => (c map (1 +)).toArray shouldBe (c.toArray map (1 +)) } | ||
| } |
There was a problem hiding this comment.
Commented because #1033.
| second.position(n + offset) | ||
| (ByteBuffer(first), ByteBuffer(second)) | ||
| } | ||
| override def map[O2](f: Byte => O2): Chunk[O2] = { |
There was a problem hiding this comment.
I haven't benchmarked this against other plausible implementations. I think this will be faster than bulk-getting the array and mapping that, but I haven't proven it.
This was referenced Dec 26, 2017
|
@ChristopherDavenport, @rossabaker looks great to me. thanks for this. lets take @mpilquist eyes on this before its merged ok ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimization for streams sourced from and sunk to
ByteBuffers. This avoids copying bytes on direct buffers, and the overhead of wrapping and unwrapping array-backed buffers.Moves
.toByteBufferoperation toChunkwithByteevidence.Brings back some properties for
Chunk, and tests the new implementation.