Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@types/ember bug] - isBlank zero-argument case #254

Closed
1 task done
mike-north opened this issue Sep 6, 2018 · 0 comments
Closed
1 task done

[@types/ember bug] - isBlank zero-argument case #254

mike-north opened this issue Sep 6, 2018 · 0 comments
Assignees
Labels
bug types:core Something is wrong with the Ember type definitions

Comments

@mike-north
Copy link
Contributor

Which package(s) does this problem pertain to?

  • @types/ember

What are instructions we can follow to reproduce the issue?

Try to type-check

import { isBlank } from '@ember/utils'

isBlank() // 💥 type-check error

Now about that bug. What did you expect to see?

I expected all of the examples in the ember docs to type-check properly

What happened instead?

TS compile error

@mike-north mike-north added types:core Something is wrong with the Ember type definitions bug labels Sep 6, 2018
@mike-north mike-north self-assigned this Sep 7, 2018
RyanCavanaugh pushed a commit to DefinitelyTyped/DefinitelyTyped that referenced this issue Sep 10, 2018
…es (#28686)

* fix: allow Ember.typeOf zero-argument case

Fixes: typed-ember/ember-cli-typescript#260

* fix: remove outdated Ember.String.fmt

Fixes: typed-ember/ember-cli-typescript#280

* fix: allow zero-argument usage of Ember.isBlank, .isEmpty, .isPresent and .isNone

Fixes typed-ember/ember-cli-typescript#258
Fixes typed-ember/ember-cli-typescript#255
Fixes typed-ember/ember-cli-typescript#256
Fixes typed-ember/ember-cli-typescript#254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug types:core Something is wrong with the Ember type definitions
Projects
None yet
Development

No branches or pull requests

1 participant