Update component and component-test blueprints #30
Conversation
simonihmig
force-pushed
the
component-blueprint
branch
from
5ffa63f to
38ce887
Compare
|
Failing tests on Windows are weird. The contents seem to match, and as this is only failing on Windows I would assume this has something to do with line endings. But I already checked that line endings are set to UNIX-style in my IDE, and Any ideas? |
Adds support for ember-mocha 0.14 Tests are copied from ember.js, after making them based on fixtures through emberjs/ember.js#17198
simonihmig
force-pushed
the
component-blueprint
branch
2 times, most recently
from
8acd88a to
e0d1e90
Compare
simonihmig
force-pushed
the
component-blueprint
branch
from
e0d1e90 to
a03dcca
Compare
|
Ok, green now ✅and ready to be merged! The last commit fixes the line endings on Windows: a03dcca Will create a backport PR for ember... |
|
@simonihmig as with the other PRs you opened, I'm sorry this sat so long! I will try to get this sorted this week! |
|
|
||
| let content = fs.readFileSync(path.join(__dirname, '../fixtures', filePath), { encoding: 'utf-8' }); | ||
| if (options.replace) { | ||
| content = content.replace(/<%= (\w+) =%>/g, (_match, key) => options.replace[key] || ''); |
There was a problem hiding this comment.
Nice! You've made it so fixtures can be factories!
Adds support for ember-mocha 0.14
Tests are copied from ember.js, after making them based on fixtures through emberjs/ember.js#17198