Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix flaky test on macOS GitHub Actions runner #4328

Merged
merged 1 commit into from
Mar 7, 2025
Merged

chore: Fix flaky test on macOS GitHub Actions runner #4328

merged 1 commit into from
Mar 7, 2025

Conversation

twpayne
Copy link
Owner

@twpayne twpayne commented Mar 7, 2025

This should eventually fix #4301. As I can't duplicate the problem locally this will be a bit noisy as I push various commits to find the flaky test.

@twpayne twpayne marked this pull request as ready for review March 7, 2025 19:53
@twpayne twpayne merged commit 1f95b69 into master Mar 7, 2025
33 checks passed
@twpayne twpayne deleted the fix-4301 branch March 7, 2025 19:53
@twpayne
Copy link
Owner Author

twpayne commented Mar 7, 2025

Well, that went quicker than expected. Looks like test-macos-3 was taking over 10 minutes most of the time, and splitting it into two solved the problem. I suspect that most of the time taken was due to setup time, as the split on S/T was in the middle and both halves take about the same amount of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test-macos-3 fails a lot
1 participant
@twpayne