Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fileExists should not require write access #407

Merged
merged 16 commits into from
Aug 26, 2022
Merged

fileExists should not require write access #407

merged 16 commits into from
Aug 26, 2022

Conversation

rectalogic
Copy link
Contributor

Fixes #406

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@dkundel
Copy link
Contributor

dkundel commented Jul 25, 2022

Thank you for the PR @rectalogic! I think overall this change makes sense but since we are using that method all over the place I'll have to see if this introduces any unexpected side-effects for files where we do expect to have write access. Will potentially have to introduce a second argument here that can be passed to enforce write access. I'll dive into this PR on Friday.

@dkundel
Copy link
Contributor

dkundel commented Jul 29, 2022

Hey @rectalogic I tried to do some modifications so that I can merge your PR but it looks like I'm hitting some TypeScript issues. I'm trying to debug it and give you an update once it's resolved.

@rectalogic
Copy link
Contributor Author

@dkundel are you referring to #409 - the toolkit is unbuildable?

dkundel and others added 14 commits August 5, 2022 15:30
@dkundel
chore: override @types/prettier to fix build
e793c65
@dkundel
chore(runtime-handler): update default twilio to 3.80.0
4cec2af 
This removes the vulnerability alerts for @twilio/runtime-handler but
might cause some side-effects for the edge case where a customer has
specified this version of runtime-handler but has not specified a
version of twilio. In this case the local and deployed behavior
might vary depending on the APIs used by the customer in Functions.
@dkundel
chore(twilio-run): update got version
091b550
@dkundel
chore(serverless-api): update got & file-type
b474072
@dkundel
fix(serverless-api): change file-type package usage
970ebbd
@dkundel
fix(twilio-run): replace listr and fix got usage
58cebe3
@dkundel
chore(serverless-api): upgrade typescript version
d6e1b42
@dkundel
test(serverless-api): temporarily turn off tests that use file-type
63b1319
@dkundel
chore(serverless-api): turn off typedoc for now
3b5d673
@dkundel
chore: remove Node 12 from Actions flow
a2eb6d4
@dkundel
chore(release): publish %s
e8fcd87 
 - [email protected]
 - @twilio-labs/[email protected]
 - @twilio-labs/[email protected]
 - @twilio/[email protected]
 - @twilio-labs/[email protected]
 - [email protected]
@rectalogic @dkundel
fileExists should not require write access
e4c90a0 
Fixes twilio-labs#406
@dkundel
fix: add option for write access check
18a053d
@dkundel
Merge branch 'file-exists' of github.com:rectalogic/serverless-toolki…
468decc 
…t into pr/rectalogic/407
@dkundel dkundel merged commit e95e726 into twilio-labs:main Aug 26, 2022
@welcome
Copy link

welcome bot commented Aug 26, 2022

Congratulations on your first contribution to the Serverless Toolkit!
If you are on the look out for more ways to contribute to open-source, check out a list of some of our repositories at https://github.com/twilio/opensource.
If you want to stay up-to-date with Twilio's OSS activities, subscribe here: https://twil.io/oss-updates
And if you love Twilio as much as we do, make sure to check out our Twilio Champions program!

@dkundel
Copy link
Contributor

dkundel commented Aug 26, 2022

Thank you for your contribution @rectalogic and sorry for the delay. I'll be cutting a release next week and will let you know about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkundel dkundel dkundel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plugin-serverless fails to deploy if package.json owned by another user
2 participants
@rectalogic @dkundel