Update phpstan-baseline.neon #4611
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore errors about Node protected properties that could be overridden in child classes with properties using hooks that would not allow unsetting array items.
|
Closing this as the failure seen in https://github.com/twigphp/Twig/actions/runs/13700986354/job/38314455486 was actually an issue in phpstan itself (unset array indexes is not an issue here) and it has already been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore errors about Node protected properties that could be overridden in child classes with properties using hooks that would not allow unsetting array items. For now, we ignore this potential issue.
The solution to fix this would be to define the properties as private in 4.0, forcing child classes to use the public methods to access them. Another solution could be to mark the property as final, but this requires PHP 8.4+