Follow symlinks of tools in nixpkgs_cc_configure #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should result in build actions that use the nix-store path to execute, rather than the workspace specific output path, which kills distributed caching.
|
@shmish111 might be the cause of what you were noticing too. |
mboes
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed poor http cache hit rates, even on the same machine when running the
same build from a different working tree. By diffing the execution log it was clear that
the path to cc_toolchain was going via the workspace's output_path, which subsequently
caused mismatching hashes.
This changes nixpkgs_cc_configure to follow symlinks of the binaries given to overriden_tools.
With this change the execution log shows nix-store paths as expected and the cache hit rates
are as expected.