Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix label construction for nix file dependencies #124

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Fix label construction for nix file dependencies #124

merged 1 commit into from
Apr 22, 2020

Conversation

mboes
Copy link
Member

@mboes mboes commented Apr 22, 2020

PR #123 fixed #113, but introduced a regression. The regression was
due to the label for the nix_file_deps files from the
nixpkgs_local_repository being constructed incorrectly.

@mboes
Fix label construction for nix file dependencies
7127361 
PR #123 fixed #113, but introduced a regression. The regression was
due to the label for the `nix_file_deps` files from the
`nixpkgs_local_repository` being constructed incorrectly.
@mboes mboes requested review from nlewo and aherrmann April 22, 2020 13:10
aherrmann
aherrmann approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@aherrmann aherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

The loop variable path_name seems to be unused now, so it can be removed.

@mboes
Copy link
Member Author

mboes commented Apr 22, 2020

Correct. In fact I have some stylistic refactoring coming up, which will deal with the unused variable as well.

@mboes mboes added the merge-queue merge on green CI label Apr 22, 2020
@mergify mergify bot merged commit a5c94b5 into master Apr 22, 2020
@mergify mergify bot deleted the fix-fix-113 branch April 22, 2020 13:39
@mergify mergify bot removed the merge-queue merge on green CI label Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aherrmann aherrmann aherrmann approved these changes

@nlewo nlewo Awaiting requested review from nlewo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nixpkgs_local_repository dependency change doesn't invalidate nixpkgs_package
2 participants
@mboes @aherrmann