Prepare test suite for traversing Python environments #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jherland
force-pushed
the
jherland/new-directory-traversal
branch
from
5f59760 to
6caf6cb
Compare
jherland
force-pushed
the
jherland/prepare-for-traversing-pyenvs
branch
from
626aa6c to
b3d8bef
Compare
jherland
force-pushed
the
jherland/new-directory-traversal
branch
from
6caf6cb to
c56e3fc
Compare
jherland
force-pushed
the
jherland/prepare-for-traversing-pyenvs
branch
from
b3d8bef to
598c293
Compare
jherland
force-pushed
the
jherland/new-directory-traversal
branch
from
59090a9 to
b6a5b32
Compare
|
🎉 All dependencies have been resolved ! |
Until now, all sample experiments have been run with a cached venv that is populated with the packages listed in the 'requirements' directive (empty by default). This commit allows experiments to declare a `pyenvs` list of directories (relative to the sample project) to be passed (via settings.pyenvs) instead of the cached venv. This will allow sample projects to embed Python environments within their project, which can then be used e.g. to test the traversal of the project directories. When given, the `pyenvs` directive will _override_ the `requirements` directive, meaning that the cached venv will no longer be used to resolve packages, only the paths passed to 'pyenvs' will be used.
This is not a real project, but merely a collection of different kinds of Python environments that we should support. In a future commit, the project traversal code in FawltyDeps will learn to auto-detect Python environments, and ignore code/deps sources otherwise found within these. When that is in place, this sample project's expected.toml will become considerably simpler, as everything should be correctly detected with default settings. For now, though, we need to pass very explicit code/deps/pyenvs options in order to compensate for FawltyDeps' lack of smarts.
One of the test vector passed a nonsense TraverseProjectVector.project member that did not point to an actual project under tests/sample_projects. Fix that, and add an assert to the test logic below to ensure this does not happen again.
We are about to introduce Python environments into the traverse_project logic. When testing the new logic we will - in addition to passing in code + deps via settings and expecting corresponding CodeSource and DepsSource objects to be created - also do the same for settings.pyenvs, resulting in the creation of PyEnvSource objects. The default mode of operation will be to auto-detect Python environments under the current project dir (as we currently do for code + deps). In order for the new logic not to interfere with the existing code/deps tests, we must therefore explicitly pass an empty pyenvs set to the existing tests. This commit does exactly that. A lot of diff noise to ensure that a future change does not change how these existing tests will work.
jherland
force-pushed
the
jherland/prepare-for-traversing-pyenvs
branch
from
598c293 to
36a78ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Depends on #324)
There are more preparatory steps on the way to integrating Python environments logic into the
traverse_projectmodule.Commits:
test_sample_projects: Accept new 'pyenvs' directive inexpected.tomlsample_projects: Addpyenv_galore'project'test_traverse_project: Fix incorrect.projectmember for a test vectortest_traverse_project: Prepare for testing with 'pyenvs'