Pin our importlib_metadata version (and some cosmetic fixes) #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jherland
force-pushed
the
jherland/multiple-pyenvs
branch
from
5e5904a to
d03225a
Compare
jherland
force-pushed
the
jherland/minor-fixes
branch
from
a7f4c88 to
0b7d7ec
Compare
jherland
force-pushed
the
jherland/multiple-pyenvs
branch
from
d03225a to
1ade7d9
Compare
jherland
force-pushed
the
jherland/minor-fixes
branch
from
0b7d7ec to
acb5882
Compare
jherland
force-pushed
the
jherland/multiple-pyenvs
branch
from
517775d to
a10e43a
Compare
|
🎉 All dependencies have been resolved ! |
v6.3.0 is the first version to include our fix for inferring top-level import names in packages using the old-style .egg installation format. However, there are more changes/fixes happening in importlib_metadata these days, and given that we depend on it quite intimately (including calling some non-publicized interfaces), we're probably better off _pinning_ it in our pyproject.toml rather than allowing our development environment to automatically encounter bugs/incompatibilities in the latest version.
jherland
force-pushed
the
jherland/minor-fixes
branch
from
acb5882 to
1e3a1bd
Compare
Nour-Mws
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Depends on #313)
Commits:
tests.utils.assert_unordered_equivalence(): More details when it failstest_invocation: Fixpytest.skip()messagepyproject.toml: Pinimportlib_metadatato latest release ==v6.6.0