Refactor resolver tests, transition to PBT #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 6, 2023
mknorps
requested changes
Apr 12, 2023
Nour-Mws
force-pushed
the
nour/refactor-resover-tests
branch
4 times, most recently
from
a04fb54 to
e7443ab
Compare
Simplify parametrized tests Extract the different categories of dependencies in the parameters into their own lists/dicts: - non_locally_installed_deps - locally_installed_deps - user_defined_deps Define the toml-formatted user mapping from the user_defined_deps dict once Instead of manually definining the expected resolved dict of deps for each case, define a function that constructs this dict by taking advantage of the fact that the sets of deps extracted above are disjoint. Move resolver tests into a separate module Replace parameterized tests with PBT
No change to functionality
Nour-Mws
force-pushed
the
nour/refactor-resover-tests
branch
from
e7443ab to
3725cef
Compare
mknorps
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
Great work on this @Nour-Mws !
I think this PR is ready to be merged 🚀
If you anyway have some spare 10 minutes, please take a look at some simplification I propose in the branch maria/nour-simplified-refactor. I described them commit by commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor was done to make it easier to test the resolver with the boolean parameters
install_depsandidentity_mapping(in future PRs).Without this refactor, the list of parameterized cases for the resolver test will grow by a factor of 2 for each additional parameter. This would require manual maintenance and is increasingly hard to parse.