Randomness conciseness #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kheuton
requested changes
Feb 20, 2024
| @@ -206,6 +206,7 @@ def calc_score_dict_uncertainty(model, x_df, y_df, split_name, | |||
| 'INTPTLAT', 'INTPTLON'] | |||
|
|
|||
| tr, va, te = make_xy_data_splits.load_xy_splits( | |||
| data_dir = '../cook-county/cleaning-cook-county/data_dir', | |||
There was a problem hiding this comment.
This shouldn't be necessary. load_xy_splits uses the data directory set by the users environment variable. I don't love the environment variable either, but by hardcoding this path here it silently breaks how the DATA_DIR environment variable works
| @@ -7,7 +7,7 @@ | |||
| parser = argparse.ArgumentParser() | |||
| parser.add_argument('--steps_to_run', default='1,2,3,4,5', type=str) | |||
| args = parser.parse_args() | |||
|
|
|||
| os.environ['DATA_DIR'] = 'data_dir' | |||
There was a problem hiding this comment.
You can add this as the default on the next line, but we shouldn't overwrite the user's environment here
There was a problem hiding this comment.
-Dont override environment variable, but can proivde ./data_dir as a default if needed
- Why was the rounding change necessary?
…ch will generate yearly semi and quarterly dfs in one command. This script also has option to add code to easily generate monthly, biweekly, and weekly dfs. The data has been rearranged to do this correct with new "data_dir" in the right spot. Also, this commit added compare_timesteps.py and compare_timesteps_fit_and_predict.py, scripts which can compare the predictive power of 2 timesteps using one as a baseline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for updated code. Changes in annual ipynb, make_xy_data_splits, and intro ipynb. data dir is now included with a couple large files removed.