Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wasm] Improve build script for macOS #2239

Merged
merged 3 commits into from
May 24, 2022
Merged

[Wasm] Improve build script for macOS #2239

merged 3 commits into from
May 24, 2022
+11 −6

Conversation

hewigovens
Copy link
Contributor

  1. Init emsdk if needed
  2. Remove patch

hewigovens added 2 commits May 24, 2022 10:29
@hewigovens
init emsdk env if needed, remove unnecessary macOS patch

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
4b9048f
@hewigovens
Add react sample link

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
22b4ccb
@hewigovens hewigovens requested a review from optout21 as a code owner May 24, 2022 01:36
optout21
optout21 approved these changes May 24, 2022
View reviewed changes
@hewigovens @optout21
Update samples/wasm/README.md

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
82e8698 
Co-authored-by: Adam V <[email protected]>
@hewigovens hewigovens merged commit 1eccbb3 into master May 24, 2022
@hewigovens hewigovens deleted the h/emsdk-init branch May 24, 2022 09:05
DeanDonkov pushed a commit to changex-app/wallet-core that referenced this pull request Apr 7, 2023
@hewigovens @DeanDonkov
[Wasm] Improve build script for macOS (trustwallet#2239)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
d1e1b4b 
* init emsdk env if needed, remove unnecessary macOS patch
* Add react sample link
* Update samples/wasm/README.md
Co-authored-by: Adam V <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@optout21 optout21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hewigovens @optout21