This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Enhancement: Include raw call data in txlog in all cases #5391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does part, but not all, of #5334. Specifically the calls part; ignored the returns part for the reasons discussed there.
Adds to
externalreturn
actions araw
field, with eitherraw.calldata
orraw.binary
(for creations). Originally I was going to make it just a single field, but I thought it was worth distinguishing? IDK.Btw, a thing I'd forgotten: For calls and creations that can't be decoded, we actually already include the raw data! So uh now we're including it twice in such cases. Oh well?
I wish I'd remembered that though when thinking about how to handle return values / errors / events in the first place! It would have been sensible to do those that way initially... oh well. Well, we can figure out exactly how we want this to work...
Also I updated two tests to test this stuff.