Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Enhancement: Include raw call data in txlog in all cases #5391

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

haltman-at
Copy link
Contributor

@haltman-at haltman-at commented Aug 4, 2022

Does part, but not all, of #5334. Specifically the calls part; ignored the returns part for the reasons discussed there.

Adds to externalreturn actions a raw field, with either raw.calldata or raw.binary (for creations). Originally I was going to make it just a single field, but I thought it was worth distinguishing? IDK.

Btw, a thing I'd forgotten: For calls and creations that can't be decoded, we actually already include the raw data! So uh now we're including it twice in such cases. Oh well?

I wish I'd remembered that though when thinking about how to handle return values / errors / events in the first place! It would have been sensible to do those that way initially... oh well. Well, we can figure out exactly how we want this to work...

Also I updated two tests to test this stuff.

@haltman-at haltman-at requested review from gnidan and cds-amal August 4, 2022 02:33
Copy link
Contributor

@gnidan gnidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! I concur about separating the two fields for calls vs. creates.

@gnidan
Copy link
Contributor

gnidan commented Aug 4, 2022

(For the redundant fields, let's just leave those for now, and we'll coordinate about it later)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants