This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Add integration tests for debug command #5263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukanyaparashar
requested review from
cds-amal,
eggplantzzz,
gnidan and
haltman-at
| readyPrompt = `debug(${displayHost})>`; | ||
| } else { | ||
| readyPrompt = `truffle(${displayHost})>`; | ||
| } |
There was a problem hiding this comment.
Thoughts on writing this as
const readyPrompt = executableCommand === "debug" ? `debug(${displayHost})>` : `truffle(${displayHost})>`;
There was a problem hiding this comment.
I like your idea of removing if/else and using a ternary instead of that, @lsqproduction. I will change this. Thanks!
cds-amal
approved these changes
Jul 7, 2022
|
Thanks for the approvals, @cds-amal and @eggplantzzz. I thought @lsqproduction's suggestions make sense. So, I applied those changes and pushed a new commit. Requested for a re-review for clarity. |
cds-amal
approved these changes
Jul 8, 2022
eggplantzzz
reviewed
Jul 8, 2022
| @@ -54,7 +54,11 @@ module.exports = { | |||
| displayHost | |||
| } = {}) { | |||
| const cmdLine = `${this.getExecString()} ${executableCommand} ${executableArgs}`; | |||
| const readyPrompt = `truffle(${displayHost})>`; | |||
|
|
|||
| const readyPrompt = | |||
There was a problem hiding this comment.
yeah this looks nicer to me :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes few integration tests for
truffle debugwhich includes the following scenarios ---networkoption with a config file.--urloption -1) with a config file.
2) without a config file (outside a truffle project).