Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-134533 / 25.10 / Add audit trail for virt plugin #15903

Merged
merged 1 commit into from
Mar 7, 2025
Merged

NAS-134533 / 25.10 / Add audit trail for virt plugin #15903

merged 1 commit into from
Mar 7, 2025

Conversation

Qubad786
Copy link
Contributor

@Qubad786 Qubad786 commented Mar 5, 2025

Context

Make sure virt plugin has an audit trail for various endpoints.

@Qubad786 Qubad786 requested a review from a team March 5, 2025 00:03
@bugclerk bugclerk changed the title Add audit trail for virt plugin NAS-134533 / 25.10 / Add audit trail for virt plugin Mar 5, 2025
@bugclerk
Copy link
Contributor

bugclerk commented Mar 5, 2025

Jira URL: https://ixsystems.atlassian.net/browse/NAS-134533

@anodos325
Copy link
Contributor

Do we need anything for the virt.volume namespace?

@anodos325
Copy link
Contributor

What about methods in virt/disk.py?

anodos325
anodos325 requested changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@anodos325 anodos325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few namespaces have been missed.

@Qubad786 Qubad786 requested a review from anodos325 March 5, 2025 13:43
@Qubad786 Qubad786 merged commit 401c605 into master Mar 7, 2025
2 checks passed
@Qubad786 Qubad786 deleted the NAS-134533 branch March 7, 2025 17:00
@bugclerk bugclerk mentioned this pull request Mar 7, 2025
Merged
@bugclerk
Copy link
Contributor

bugclerk commented Mar 7, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anodos325 anodos325 anodos325 approved these changes

Assignees
No one assigned
Labels
backport-25.04.0 backported no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Qubad786 @bugclerk @anodos325