NAS-130424 / None / scsi: mpi3mr: NVMe encapsulation support for tri-mode HBA #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
ixhamza
force-pushed
the
NAS-130424-6.12-2
branch
from
eb173a3 to
f1512b1
Compare
amotin
approved these changes
Nov 26, 2024
The driver serializes IOCTLs through a mutex lock, but the access to IOCTL data buffer is not guarded by the lock.It causes multiple user threads writing to the driver's ioctl buffer simultaneously. Access to the IOCTL data buffer is guarded by the IOCTL mutex lock. Signed-off-by: Sumit Saxena <[email protected]> Signed-off-by: Ranjan Kumar <[email protected]>
ixhamza
force-pushed
the
NAS-130424-6.12-2
branch
from
f1512b1 to
5875e73
Compare
ixhamza
force-pushed
the
NAS-130424-6.12-2
branch
from
5875e73 to
5bf0848
Compare
amotin
approved these changes
Nov 27, 2024
|
@usaleem-ix - I have cherry-picked mpi3mr: synchronize the access to ioctl data buffer after @amotin identified a bug during internal review though the commit is still pending upstream approval. Just a heads up, in case you encounter conflicts during a later merge. |
|
Not updating JIRA ticket https://ixsystems.atlassian.net/browse/NAS-130424 target versions as no JIRA version corresponds to this PR |
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: https://ixsystems.atlassian.net/browse/NAS-130424
Scale Build: http://jenkins.eng.ixsystems.net:8080/job/master/job/custom/760/
Test Machine: m60.mav.ixsystems.net
Kernel 6.6 PR: #199