Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade MySQL driver to 8.x #7201

Closed
wants to merge 3 commits into from

Conversation

hashhar
Copy link
Member

@hashhar hashhar commented Mar 7, 2021

Based on #7198 to preserve MariaDB compat.

This change migrates trino-mysql to Connector/J 8.0.22 from 5.1.48 while keeping other modules at 5.1.48 for now.

This should unblock #6910.

Fixes #443

@cla-bot cla-bot bot added the cla-signed label Mar 7, 2021
hashhar added 2 commits March 8, 2021 02:34
Upgrade MySQL driver to 8.0.22 for trino-mysql keeping other modules at
5.1.48
@hashhar hashhar force-pushed the hashhar/mysql-driver-upgrade branch from 04866c9 to ec64d12 Compare March 7, 2021 21:04
@hashhar
Copy link
Member Author

hashhar commented Mar 8, 2021

CI is failing for testDatetime and testTimestamp in TestMySqlTypeMapping because the JDBC driver now correctly handles values in a DST gap.

I'd like to wait for #7166 to be merged to avoid conflicts.

@findepi
Copy link
Member

findepi commented Mar 8, 2021

Does this replace #470 ?

@hashhar
Copy link
Member Author

hashhar commented Mar 8, 2021

This intends to replace #470 once I add fixups that upgrade driver version in modules other than trino-mysql.

@hashhar
Copy link
Member Author

hashhar commented Jun 23, 2021

I see this got done in 01670f3. Thanks @guyco33 .

@hashhar hashhar closed this Jun 23, 2021
@hashhar hashhar deleted the hashhar/mysql-driver-upgrade branch June 23, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

MySQL connector prints NPE during SELECT
2 participants