Send query heartbeat while spooled data is downloaded #25267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
approved these changes
Mar 10, 2025
This prevents a situation when long list of segments is returned and client slowly progresses over it which could take longer than a query abandoned timeout. This change allows to send a heartbeat while client is progressing over data.
wendigo
force-pushed
the
serafin/spooled-heartbeat
branch
from
070346a to
7b599b7
Compare
losipiuk
reviewed
Mar 11, 2025
| @@ -388,6 +397,50 @@ public boolean advance() | |||
| return executeRequest(request, "fetching next", (e) -> true); | |||
| } | |||
|
|
|||
| public void heartbeat() | |||
There was a problem hiding this comment.
Maybe rename to heartbeatIfNeeded
losipiuk
reviewed
Mar 11, 2025
| private final boolean isNull; | ||
| private final Runnable heartbeat; | ||
|
|
||
| public HeartbeatingResultRows(ResultRows delegate, Runnable heartbeat) |
There was a problem hiding this comment.
Can you add unit test for this one?
There was a problem hiding this comment.
I can try but I need to think how to do it. The default keep-alive interval is 30s
There was a problem hiding this comment.
You would need some parametrization; at least @VisibleForTests. And possibly some mockings. See if that is not too much of spaghetti
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a situation when long list of segments is returned and client slowly progresses over it which could take longer than a query abandoned timeout.
This change allows to send a heartbeat while client is progressing over data.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: