Add number option to preserve in Iceberg expire_snapshots procedure
#25265
+66
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
commented
Mar 10, 2025
| @@ -36,6 +39,16 @@ public TableProcedureMetadata get() | |||
| "retention_threshold", | |||
| "Only snapshots older than threshold should be removed", | |||
| Duration.valueOf("7d"), | |||
| false), | |||
| integerProperty( | |||
| "retain_last", | |||
There was a problem hiding this comment.
I used the parameter name which is the same as Spark here, but min_snapshots or something might be better. Other suggestions are welcome.
There was a problem hiding this comment.
retain_last sounds consistent with retention_threshold - I'd vote for that option
ebyhr
force-pushed
the
ebi/iceberg-expire-snaphosts-retain-last
branch
2 times, most recently
from
bf45246 to
0dd6346
Compare
ebyhr
force-pushed
the
ebi/iceberg-expire-snaphosts-retain-last
branch
from
0dd6346 to
415e2fd
Compare
SemionPar
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
retain_lastoption toexpire_snapshotsprocedure in Iceberg connector.Spark supports this option. https://iceberg.apache.org/docs/latest/spark-procedures/#expire_snapshots
Request in Trino Slack: https://trinodb.slack.com/archives/C0305TQ05KL/p1741348205204709
Release notes