Remove Databricks unity catalog product tests #25250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findinpath
reviewed
Mar 7, 2025
.github/workflows/ci.yml
Outdated
| @@ -900,7 +900,7 @@ jobs: | |||
| - suite-delta-lake-databricks133 | |||
| - suite-delta-lake-databricks143 | |||
| - suite-delta-lake-databricks154 | |||
| - suite-databricks-unity-http-hms | |||
| # suite-databricks-unity-http-hms fails with `FEATURE_DISABLED: HMS compatibility with Unity Catalog is currently in private preview.` | |||
There was a problem hiding this comment.
Do we want to disable the tests or remove them altogether?
It is not like they'll eventually get re-enabled.
There was a problem hiding this comment.
@mayankvadariya Please file a GitHub issue if you plan to re-enable this test in the future.
There was a problem hiding this comment.
I removed unity catalog tests
There was a problem hiding this comment.
What's the future plan of the relevant non-test code?
Please avoid abbreviations. https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#avoid-abbreviations |
mayankvadariya
force-pushed
the
mayank/disable-unity-tests
branch
from
b0e362b to
74b3faf
Compare
Tests are failing with `Error from Unity Catalog service: FEATURE_DISABLED: HMS compatibility with Unity Catalog is currently in private preview. For more information, please contact your Databricks representative.` error
mayankvadariya
force-pushed
the
mayank/disable-unity-tests
branch
from
74b3faf to
7abc841
Compare
mayankvadariya
changed the title
findinpath
reviewed
Mar 10, 2025
Comment on lines
-1086
to
-1087
| DATABRICKS_LOGIN: token | ||
| DATABRICKS_TOKEN: ${{ secrets.DATABRICKS_TOKEN }} |
There was a problem hiding this comment.
These env variables likely make sense for other Databricks tests
findinpath
reviewed
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable unity PT as its failing on master https://github.com/trinodb/trino/actions/runs/13719592708/job/38372369092#step:7:3003
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.