Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust to the moved Helm chart #558

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Adjust to the moved Helm chart #558

merged 3 commits into from
Dec 2, 2024

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Nov 29, 2024

Description

As discussed in dev sync.

Additional context and related issues

Related to trinodb/charts#268

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

Copy link
Contributor

@willmostly willmostly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment but I think this is good to merge

@@ -204,8 +204,16 @@ java -XX:MinRAMPercentage=50 -XX:MaxRAMPercentage=80 \
### Helm <a name="helm"></a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is linked from docker.md - perhaps it should just link directly to the chart repo - wdyt?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No .. I want to keep this since I want to actually get this onto a separate page and much improved.. so for now .. lets leave as is

@mosabua mosabua merged commit 1ba6629 into trinodb:main Dec 2, 2024
2 checks passed
@mosabua mosabua deleted the chart branch December 2, 2024 19:51
@github-actions github-actions bot added this to the 13 milestone Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants