Allow autoscaling by memory utilization #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineinchnick
approved these changes
Oct 3, 2024
nineinchnick
changed the title
|
Also, please remove the |
dantonbertuol
force-pushed
the
feature/memory-resource-autoscaling
branch
from
569e066 to
340b393
Compare
dantonbertuol
force-pushed
the
feature/memory-resource-autoscaling
branch
from
340b393 to
7f0dd0e
Compare
nineinchnick
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This PR aims to enable the possibility of using memory resource in the HPA. I noticed that there is an open PR (#219) regarding this, but it has been inactive for a month, and this is a feature I really need.
A new variable has been created in the values (targetMemoryUtilizationPercentage), with a default value of 80. In the HPA manifest, I added a conditional check to see if a value is set for this variable, allowing the assignment of an empty value ("") to one of them to not use the metric. I also included this condition for targetCPUUtilizationPercentage (since someone might not want to scale based on CPU).