Eckhart UI - bootloader #4765
Open
Eckhart UI - bootloader #4765
+1,493
−1,546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
obrusvit
force-pushed
the
ui-eckhart
branch
2 times, most recently
from
34e6691 to
acbc741
Compare
obrusvit
force-pushed
the
obrusvit/eckhart-bootloader-2
branch
from
87127ec to
816b684
Compare
obrusvit
force-pushed
the
obrusvit/eckhart-bootloader-2
branch
from
816b684 to
c80d6c3
Compare
obrusvit
force-pushed
the
obrusvit/eckhart-bootloader-2
branch
from
c80d6c3 to
af4a566
Compare
obrusvit
requested review from
bieleluk and
TychoVrahe
and removed request for
prusnak
obrusvit
force-pushed
the
obrusvit/eckhart-bootloader-2
branch
from
fe91a3a to
dce6d5b
Compare
obrusvit
force-pushed
the
ui-eckhart
branch
2 times, most recently
from
09e52b0 to
5778366
Compare
- skimmed variants from firmware
- implementation using the new bootloader components - the implementation sits in the separate file `ui_bootloader.rs`
obrusvit
force-pushed
the
obrusvit/eckhart-bootloader-2
branch
from
dce6d5b to
71c078f
Compare
bieleluk
requested changes
Mar 12, 2025
| pub const BLD_FG: Color = WHITE; | ||
| pub const BLD_WIPE_COLOR: Color = Color::rgb(0xE7, 0x0E, 0x0E); | ||
| pub const BLD_WIPE_TEXT_COLOR: Color = WHITE; | ||
|
|
||
| pub const BLD_WARN_COLOR: Color = Color::rgb(0xFF, 0x00, 0x00); |
There was a problem hiding this comment.
The warning color in Figma has value 0xFF3030, which is similar to RED in theme/mod.rs.
| ButtonStyleSheet { | ||
| normal: &ButtonStyle { | ||
| font: fonts::FONT_SATOSHI_MEDIUM_26, | ||
| text_color: GREY_LIGHT, | ||
| button_color: BLD_BG, | ||
| button_color: GREY_EXTRA_DARK, |
There was a problem hiding this comment.
According to Figma, this should be GREY_SUPER_DARK
| @@ -99,54 +44,54 @@ pub fn button_confirm() -> ButtonStyleSheet { | |||
| } | |||
| } | |||
|
|
|||
| pub const fn button_header() -> ButtonStyleSheet { | |||
| pub fn button_cancel() -> ButtonStyleSheet { | |||
| ButtonStyleSheet { | |||
| normal: &ButtonStyle { | |||
| font: fonts::FONT_SATOSHI_MEDIUM_26, | |||
| text_color: GREY_LIGHT, | |||
There was a problem hiding this comment.
According to Figma, this should be GREY_EXTRA_LIGHT
| ButtonStyleSheet { | ||
| normal: &ButtonStyle { | ||
| font: fonts::FONT_SATOSHI_MEDIUM_26, | ||
| text_color: GREY_LIGHT, | ||
| button_color: BLD_BG, | ||
| button_color: GREY_EXTRA_DARK, | ||
| icon_color: GREY_LIGHT, |
| } | ||
|
|
||
| impl BldMenu { | ||
| const SIDE_INSETS: Insets = Insets::sides(24); |
There was a problem hiding this comment.
Can we use the same constants from theme/mod.rs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.