Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add topspace-active, improve topspace-autocenter-buffers #4

Merged
merged 2 commits into from
Mar 4, 2022

Conversation

trevorpogue
Copy link
Owner

@trevorpogue trevorpogue commented Mar 4, 2022

Resolves #3.

  • Add customizable variable topspace-active to determine when topspace-mode mode is active / has any effect on buffer.
    It can be set to t, nil, or a predicate function. This is useful in particular when global-topspace-mode is enabled but you want
    topspace-mode to be inactive in certain buffers or in any specific
    circumstance. When inactive, topspace-mode will still technically be on,
    but will be effectively off and have no effect on the buffer.

  • Allow topspace-autocenter-buffers to be either t, nil, or a predicate function (before it could only be t or nil)


Checklist

  • I have read the topspace contributing guidelines
  • My changes follow the Emacs Lisp conventions and the Emacs Lisp Style Guide
  • I've used the latest version of package-lint to check for packaging issues, and addressed its feedback
  • The new code is not generating bytecode warnings or M-x checkdoc warnings -- False positives for text with topspace-mode
  • I've updated the changelog (if adding/changing user-visible functionality) -- We're going to transition to automatic changelog generator instead
  • I've updated the readme (if adding/changing user-visible functionality)
  • I have confirmed some of these without doing them

@trevorpogue trevorpogue changed the title Active Add customizable variable topspace-active Mar 4, 2022
@trevorpogue trevorpogue changed the title Add customizable variable topspace-active Add topspace-active, make topspace-autocenter-buffers more flexible Mar 4, 2022
@trevorpogue trevorpogue changed the title Add topspace-active, make topspace-autocenter-buffers more flexible Add topspace-active, improve topspace-autocenter-buffers Mar 4, 2022
@trevorpogue trevorpogue merged commit f47c9f9 into main Mar 4, 2022
@trevorpogue trevorpogue deleted the active branch March 4, 2022 23:35
@trevorpogue trevorpogue added the enhancement New feature or request label Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: customize a blacklist of mode where topspace should not be activated
1 participant