Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inability to use scrolling commands interactively #11

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Fix inability to use scrolling commands interactively #11

merged 1 commit into from
Apr 13, 2022

Conversation

trevorpogue
Copy link
Owner

Scrolling commands such as scroll-down-command, scroll-down were not working
when called interactively or with a nil argument. This is fixed here.

Checklist

  • I have read the topspace contributing guidelines
  • My changes follow the Emacs Lisp conventions and the Emacs Lisp Style Guide
  • I've used the latest version of package-lint to check for packaging issues, and addressed its feedback
  • The new code is not generating bytecode warnings
  • I've updated the readme (if adding/changing user-visible functionality)
  • I have confirmed some of these without doing them

@trevorpogue trevorpogue added the bug Something isn't working label Apr 13, 2022
@trevorpogue trevorpogue merged commit c326169 into main Apr 13, 2022
@trevorpogue trevorpogue deleted the scroll-interactively-bug branch April 13, 2022 03:05
trevorpogue added a commit that referenced this pull request Apr 13, 2022
@trevorpogue
Fix bug caused by #11 when scrolling with topspace disabled
e3cd398 
- #11 caused a bug where is was not possible to scroll anymore if
  topspace is disabled in the current buffer. This resolves that issue.
trevorpogue added a commit that referenced this pull request Apr 13, 2022
@trevorpogue
Fix mwheel mouse scrolling down bug causes by #11
8fcd11d 
- #11 caused a bug with mouse scrolling - when scrolling down
  it would move buffer suddenly all the way to the bottom
  in some cases. This resolves that issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@trevorpogue