Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the BinarySearch component from a function to an arrow function. #999

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ben-lad
Copy link

@Ben-lad Ben-lad commented Feb 20, 2023

Changed the BinarySearch component from a function to an arrow function.

The original component was defined using the function keyword, but I updated it to use an arrow function instead. This change provides a more concise syntax and also avoids any issues with the binding of the "this" keyword.

I have tested the updated component and verified that it works as expected.

Thanks for considering this change!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Changed the BinarySearch component from a function to an arrow function.

The original component was defined using the function keyword, but I updated it to use an arrow function instead. This change provides a more concise syntax and also avoids any issues with the binding of the "this" keyword.

I have tested the updated component and verified that it works as expected.

Thanks for considering this change!
@lazarljubenovic
Copy link

It's a top-level function. There's no issue with "this", nor is it more concise. Also it's not a component.

Consider common sense before spamming multiple repositories with the same artificial-not-so-intelligent type of changes.

@leomosia
Copy link

It's a top-level function. There's no issue with "this", nor is it more concise. Also it's not a component.

Consider common sense before spamming multiple repositories with the same artificial-not-so-intelligent type of changes.

don't that hard on the guy, he might still be learning and just wants to contribute.

@lazarljubenovic
Copy link

I looked at his profile; he had the same comments in other repos. It's a bot.

@Ben-lad
Copy link
Author

Ben-lad commented Mar 16, 2023

@lazarljubenovic I'm really sorry for that, if that make you angry. I'm not a bot just still learning as @iamleomoko said, and am looking for something small to change in the code. I'll delete this now
So am really sorry once again.

@iamleomoko Thank you for saying that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants