Add minimax algorithm #870
Open
+387
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heuristic and game state definition still missing. No tests yet.
Old GameNode is called TicTacToeGameNode as it is used to represent tic tac toe game states. The idea is that any game implementing the GameNode interface should be able to use the Minimax algorithm.
Changes findBestMove and minimax to be correct regardless of player associated with a game state. Adds to the GameNode interface a required method getMove, which should return the move which caused the game state defined by the GameNode. Adds a test which exemplifies the previous issue and a few tests checking the functionality of minimax when used on a Tic Tac Toe game.
cikay
reviewed
Apr 11, 2022
| if (Array.isArray(board) && board.length === 3) { | ||
| for (let i = 0; i < 3; i += 1) { | ||
| const row = board[i]; | ||
| if (Array.isArray(row) && row.length === 3) { |
There was a problem hiding this comment.
Reverse condition and add continue statement to decrease indentation level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #566