Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the insertion sort #86

Merged
merged 25 commits into from
Jul 3, 2018
Merged

Fix the insertion sort #86

merged 25 commits into from
Jul 3, 2018

Conversation

m-maksyutin
Copy link
Contributor

Hi, this is fixing the situation when we have an unsorted array with negative numbers and zeroes.

MikhailMaksyutin and others added 25 commits June 1, 2018 15:19

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
# Conflicts:
#	src/data-structures/tree/binary-search-tree/BinarySearchTreeNode.js
# Conflicts:
#	src/data-structures/graph/Graph.js
@codecov-io
Copy link

Codecov Report

Merging #86 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #86   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         100    100           
  Lines        2029   2029           
  Branches      354    354           
=====================================
  Hits         2029   2029
Impacted Files Coverage Δ
...algorithms/sorting/insertion-sort/InsertionSort.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3b482c...96efc15. Read the comment docs.

@trekhleb
Copy link
Owner

trekhleb commented Jul 3, 2018

Thank you for the fix @m-maksyutin

@trekhleb trekhleb merged commit d82958d into trekhleb:master Jul 3, 2018
shoredata pushed a commit to shoredata/javascript-algorithms that referenced this pull request Mar 28, 2019
* Fix LinkedList

* Fix the prepend method for the LinkedList

* Fix the remove method for the MinHeap

* Correct a comment

* Fix BST removal method

* Fix the findEdge method of the graph

* Fix the value returned by DisjointSet union

* Add recursive factorial function

* Fix the insertion sort
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants