Fix BST removal method #74
Merged
+26
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 89 89
Lines 1929 1932 +3
Branches 342 343 +1
=====================================
+ Hits 1929 1932 +3
Continue to review full report at Codecov.
|
|
Thank you for the fix @m-maksyutin |
tstillwell
added a commit
to tstillwell/javascript-algorithms
that referenced
this pull request
Jun 29, 2018
* chore: ignore .DS_Store in git (trekhleb#65) * Fix BST removal method. * Simplify combineWithoutRepetition algorithm. * add recursive solution to permutations with repetitions problem (trekhleb#52) * add recursive solution to permutations with repetitions problem * fix untested function, failing test * add comments * Add recursive way of generating permutations with repetitions. * Code style fixes. * Update javascript-algorithms-and-data-structures version. * fix unbound knapsack problem with items more than 1(default value) (trekhleb#73) * Code style fixes. * Correct a comment (trekhleb#66) * Fix LinkedList * Fix the prepend method for the LinkedList * Fix the remove method for the MinHeap * Correct a comment * Add algorithms complexity to README. * Update README. * Z algorithm implementation (trekhleb#77) * Implemented Z algorithm * Fixed bugs in implementation and added tests * Added README explaining z algorithm * Code style fixes. * Add comments. * Add comments. * Fix BST removal method (trekhleb#74) * Fix LinkedList * Fix the prepend method for the LinkedList * Fix the remove method for the MinHeap * Correct a comment * Fix BST removal method * Add setValue and nodeCopy methods to binary tree node. * Corrected explanations and included an example (trekhleb#75) * Update README for integer partition. * Added Complexity of Each Algorithm in Sorting/ directory. (trekhleb#76) * Added Complexity to Bubble Sort README.md * Added Complexity to Counting-Sort README.md * Italicized n in Bubble Sort README.md * Added Complexity to Heap Sort README.md * Added Complexity to Insertion Sort README.md * Added Complexity to Merge Sort README.md * Added Complexity to Quick Sort README.md * Added Complexity to Radix Sort README.md * Added Complexity to Selection Sort README.md * Added Complexity to SHell Sort README.md * Update READMEs. * Update READMEs. * Update READMEs. * Update READMEs. * Update READMEs. * Update READMEs. * Update READMEs. * Update READMEs. * Update READMEs. * Update READMEs. * Add Levenshtein Distance algorithm explanations. * Fix the findEdge method of the graph (trekhleb#80) * Fix LinkedList * Fix the prepend method for the LinkedList * Fix the remove method for the MinHeap * Correct a comment * Fix BST removal method * Fix the findEdge method of the graph * Code style fix. * Add regular expression matching algorithm. * Fix the value returned by DisjointSet union (trekhleb#81) * Fix LinkedList * Fix the prepend method for the LinkedList * Fix the remove method for the MinHeap * Correct a comment * Fix BST removal method * Fix the findEdge method of the graph * Fix the value returned by DisjointSet union * Add bit manipulation section. * Add more bit manipulation functions. * Add more bit manipulation functions. * Fix typo. * Simplify combineWithoutRepetitions function. * Simplify combineWithRepetitions function. * Add recursive factorial function (trekhleb#85) * Fix LinkedList * Fix the prepend method for the LinkedList * Fix the remove method for the MinHeap * Correct a comment * Fix BST removal method * Fix the findEdge method of the graph * Fix the value returned by DisjointSet union * Add recursive factorial function * Simplify permutateWithRepetitions algorithm.
shoredata
pushed a commit
to shoredata/javascript-algorithms
that referenced
this pull request
Mar 28, 2019
* Fix LinkedList * Fix the prepend method for the LinkedList * Fix the remove method for the MinHeap * Correct a comment * Fix BST removal method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with the parent node. Now the removal method works for nodes with no parent.