Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding of a method that get the successor of a node inside the birany search tree #589

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

dilane3
Copy link

@dilane3 dilane3 commented Dec 12, 2020

I have added one file to your repository, this file contains a function which take a number and returns the power of two which is directly greater than the given number. I have also added a test file and a README file.

@codecov
Copy link

codecov bot commented Dec 12, 2020

Codecov Report

Merging #589 (4917139) into master (1b0e27a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #589   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          153       154    +1     
  Lines         2645      2649    +4     
  Branches       438       439    +1     
=========================================
+ Hits          2645      2649    +4     
Impacted Files Coverage Δ
...greater-than-number/powerOfTwoGreaterThanNumber.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b0e27a...4917139. Read the comment docs.

@dilane3 dilane3 changed the title Add a function powerOfTwoGreaterThanNum Add a function powerOfTwoGreaterThanNumber Dec 12, 2020
@dilane3
Copy link
Author

dilane3 commented Dec 13, 2020

How can I complete my checks ?, I remark that I need to do the continuous integration but how can I do it ?
Thanks

@lazarljubenovic
Copy link

To be honest, this looks more like basic logarithm operations for a math class and less like a CS algorithm for this repo. Maybe if the code found the first 1 in the binary representation and cleared bits on the right?

@dilane3 dilane3 closed this Dec 13, 2020
@dilane3 dilane3 reopened this Dec 13, 2020
@dilane3
Copy link
Author

dilane3 commented Dec 13, 2020

For you I should not use the logarithm operation ? because this looks more like the math class ?

@lazarljubenovic
Copy link

I'm not commenting on the code itself, I'm commenting on its inclusion in the project which has the usual bunch of CS algorithms. Calculating the "next power of two" is just applying the well-known logarithm function. In my opinion, it doesn't fit here. But I'm not the maintainer, just giving my two cents.

@dilane3
Copy link
Author

dilane3 commented Dec 13, 2020

Ok. I understand that you say. But I wanted to do it because I have another contribution for this repository and which use it, then I have seen better to separate it.

This is my first pull request. I am a beginner, I would like to learn about git GitHub and JavaScript.

trekhleb and others added 4 commits December 15, 2020 18:20

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…e some value inside the function successor for getting the successor of a node
@dilane3 dilane3 changed the title Add a function powerOfTwoGreaterThanNumber Adding of a method that get the successor of a node inside the birany search tree Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants